Duplicate entries in docker node ps when multi nodes are passed #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsan-salamati
force-pushed
the
4155-fix-docker-node-ps-duplicate-enteries-for-multi-nodes-passed
branch
from
08cb5ca
to
274d087
Compare
…. For example, 'docker ps node node1 node2'. Signed-off-by: Ehsan Salamati <[email protected]>
ehsan-salamati
force-pushed
the
4155-fix-docker-node-ps-duplicate-enteries-for-multi-nodes-passed
branch
from
274d087
to
94b0eb8
Compare
ehsan-salamati
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5314 +/- ##
=======================================
Coverage 61.45% 61.45%
=======================================
Files 299 299
Lines 20855 20855
=======================================
Hits 12816 12816
Misses 7124 7124
Partials 915 915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes #4155 duplicate entries in docker node ps when multi nodes are passed
- How I did it
When running the docker node ps command with multiple nodes in the for loop, the filter state retains node-specific data from previous iterations, causing task entries to be duplicated for the first specified node. This occurs because the filter object, being a dictionary type, was reused and modified across iterations, accumulating previous node filters.
- How to verify it
docker node pscommand.Before:
After :
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)